Skip to content

feat(web): General Chats can be a section of Threads instead of their own page - #1031

Merged
badcuban merged 5 commits into
mainfrom
feat/general-chats-placement
Nov 21, 2026
Merged

badcuban merged 5 commits into
mainfrom
feat/general-chats-placement

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Closes #1016.

A new setting, Settings › Threads › Sidebar › General chats, picks where General Chats live. "Own page" (the default) is today's rail button and page, unchanged. "Section in Threads" removes the rail button and lists the chats in a fold-out section at the bottom of the Threads list, under Wrapped, with a New chat button on its header. Each device keeps its own choice, and switching back restores the rail button and page.

In section mode:

  • The rail button's needs-you count, working count and unread dot move onto the Threads button.
  • A folded section still shows the open chat's row, and its header says what the hidden chats need.
  • /chats, place links, the command palette's "Open general chats" and the desktop menu open Threads with the section unfolded, including the floating list in a narrow window and the phone sheet.
  • New chat is on the section header, the existing "General chat" picker item, and a new palette action "New general chat".
  • Previous/next thread walks the whole list when the section is open. The section follows the computer filter.

The Wrapped and General chats headers now share one component (InboxShelfHeader), and the chat rows are shared between the page and the section.

Review fixes from GPT-6.2 Astra: launching straight onto /chats in a narrow window kept the floating list; switching back to Own page no longer leaves Threads pointing at a chat; previous/next crosses into and out of the section; the section follows the computer filter; "Open general chats" adds no duplicate Back entry.

Checked: fmt, lint, typecheck, unit tests for the touched modules, new browser tests (section mode end to end, phone sheet, floating list), full web browser suite (one hover test failed under load and passes alone), polish check in light and dark.

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 21, 2026 1:26am UTC

Request Review

… own page

Issue #1016 asked for General Chats at the bottom of the Threads list so
switching between project work and chats takes no extra step. Some people
like the separate page, so this is a per-device choice: Settings > Threads >
Sidebar > General chats, "Own page" (default, unchanged) or "Section in
Threads".

In section mode the General Chats rail button goes away and its counts move
onto Threads. The chats sit in a fold-out section under Wrapped with the same
header line (now one shared InboxShelfHeader) and a New chat button; folded,
it keeps the open chat's row and says what the hidden chats need or are doing.
/chats, and so the command palette, desktop menu and place links, opens
Threads with the section open, showing a floating list or the phone sheet.
The inbox column leaves the section its room. The chat rows are shared with
the page list (GeneralChatRows), and the palette gains "New general chat".
… without a detour

Review fixes on the General chats section:

- Opening it from the command palette or the desktop menu no longer stops at
  /chats: a request goes to one GeneralChatsRevealer in the shell, which
  unfolds the section, shows the list or the phone sheet, and moves to Threads
  only when Threads isn't already on screen. Back no longer repeats the
  thread you were on.
- A launch straight onto /chats in a narrow window keeps the floating list
  showing through home's own redirect to the last thread.
- Switching back to the chats' own page no longer leaves the Threads button
  pointing at a general chat: it remembers project work separately.
- With the section open, previous/next walk the whole list top to bottom,
  from the last project thread into the chats and back.
- With the list narrowed to one computer, the section lists only that
  computer's chats and New chat starts there.
The section and its chat rows are now a chunk of their own, fetched only on
a device that lists General Chats in Threads, and the revealer mounts only
there. The section takes the sheet's close action as a prop rather than
importing the sidebar's context, which would have split that context out of
the startup bundle. Reveal requests now wait as a pending count, so one made
before the revealer mounts is still carried out.

Startup closure, local build: 924,408 B before, 912,235 B after (main reads
910,464 B).
@badcuban
badcuban force-pushed the feat/general-chats-placement branch from 93c9b0a to ef5d194 Compare November 21, 2026 01:25
@badcuban
badcuban added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit fa7bb66 Nov 21, 2026
23 checks passed
@badcuban
badcuban deleted the feat/general-chats-placement branch November 21, 2026 01:37

This branch was previously deployed

1 inactive deployment
Preview — ef5d1945 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Put General Chats in a collapsible section of Threads

1 participant